Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement:] cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties #28162

Closed
wants to merge 2 commits into from

Conversation

WodansSon
Copy link
Collaborator

@WodansSon WodansSon commented Dec 3, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Upgrade API version for webapplicationfirewallpolicies to 2024-02-01 to expose the ActionTypeJSChallenge property
Upgrade API version for webapplicationfirewallmanagedrulesets to 2024-02-01 to expose the jschallenge property

  • cdn_frontdoor_firewall_policy_data_source - update API
  • cdn_frontdoor_firewall_policy - update API
  • cdn_frontdoor_helpers - update API
  • cdn_frontdoor_rule_resource - update API
  • cdn_frontdoor_shared_schema - update API

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_resource - support for the thing1 property [GH-00000]

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27325

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

Depends on #28211
Depends on #28233

@WodansSon WodansSon requested a review from a team as a code owner December 3, 2024 09:25
@WodansSon WodansSon marked this pull request as draft December 3, 2024 09:26
@WodansSon WodansSon changed the title [Enhancement]: cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge` propertie [Enhancement]: cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties Dec 3, 2024
@WodansSon
Copy link
Collaborator Author

NOTE: Getting the jschallenge and ActionTypeJSChallege fields exposed in the provider will be delayed a bit as there was a regression discovered in the go-azure-sdk, please see PR #28211 for more details.

@WodansSon WodansSon added the upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora` label Dec 7, 2024
@WodansSon WodansSon changed the title [Enhancement]: cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties **Enhancement:** cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties Dec 7, 2024
@WodansSon WodansSon changed the title **Enhancement:** cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties [Enhancement:] cdn_frontdoor_firewall_policy_data_source, cdn_frontdoor_firewall_policy, cdn_frontdoor_helpers, cdn_frontdoor_rule_resource and cdn_frontdoor_shared_schema - expose the jschallenge and ActionTypeJSChallenge properties Dec 7, 2024
@WodansSon WodansSon closed this Dec 14, 2024
@WodansSon WodansSon deleted the e_frontdoor_waf_policies branch December 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies enhancement service/cdn size/XL upstream/pandora This issue/PR has a dependency on an issue in `github.com/hashicorp/pandora`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for JS Challenge in resource azurerm_cdn_frontdoor_firewall_policy
1 participant